xonecas.io
60255
Zn

Zoea-Nova / commit 2040f73

refactor(config): remove BootstrapAgents and DefaultAgents

BootstrapAgents was a test utility that leaked into production code,
auto-creating agents on startup. Users should explicitly create agents.

Removed:
- BootstrapAgents() method from Commander
- DefaultAgents config field from SwarmConfig
- ZOEA_DEFAULT_AGENTS environment variable override
- Related test (TestCommanderBootstrapAgents)

The app now starts with zero agents; users create them with 'n' key.

xonecas2026-02-04 2040f7389bd59cfef27dc03aecc7e8f59dcfeac6 parent 83403be

3 files changed

cmd/zoea/main.go+56−7
@@ -86,12 +86,19 @@ func main() {
8686 // Initialize commander
8787 commander := core.NewCommander(s, registry, bus, cfg)
8888
89- // Load existing agents
89+ // Load existing agents from database
9090 if err := commander.LoadAgents(); err != nil {
9191 log.Warn().Err(err).Msg("Failed to load existing agents")
9292 }
9393 log.Debug().Int("agents", commander.AgentCount()).Msg("Agents loaded")
9494
95+ // Auto-start all existing agents on launch
96+ for _, a := range commander.ListAgents() {
97+ if err := a.Start(); err != nil {
98+ log.Warn().Err(err).Str("agent", a.Name()).Msg("Failed to start agent")
99+ }
100+ }
101+
95102 // Initialize MCP proxy
96103 mcpProxy := mcp.NewProxy(cfg.MCP.Upstream)
97104 mcp.RegisterOrchestratorTools(mcpProxy, &commanderAdapter{commander})
@@ -242,12 +249,46 @@ func (a *commanderAdapter) MaxAgents() int {
242249 return a.commander.MaxAgents()
243250 }
244251
245-func (a *commanderAdapter) SendMessage(agentID, message string) error {
246- return a.commander.SendMessage(agentID, message)
252+func (a *commanderAdapter) SendMessageAsync(agentID, message string) error {
253+ return a.commander.SendMessageAsync(agentID, message)
247254 }
248255
249-func (a *commanderAdapter) Broadcast(message string) error {
250- return a.commander.Broadcast(message)
256+func (a *commanderAdapter) BroadcastAsync(message string) error {
257+ return a.commander.BroadcastAsync(message)
258+}
259+
260+func (a *commanderAdapter) SearchMessages(agentID, query string, limit int) ([]mcp.SearchResult, error) {
261+ memories, err := a.commander.Store().SearchMemories(agentID, query, limit)
262+ if err != nil {
263+ return nil, err
264+ }
265+
266+ results := make([]mcp.SearchResult, len(memories))
267+ for i, m := range memories {
268+ results[i] = mcp.SearchResult{
269+ Role: string(m.Role),
270+ Source: string(m.Source),
271+ Content: m.Content,
272+ CreatedAt: m.CreatedAt.Format("2006-01-02 15:04:05"),
273+ }
274+ }
275+ return results, nil
276+}
277+
278+func (a *commanderAdapter) SearchBroadcasts(query string, limit int) ([]mcp.BroadcastResult, error) {
279+ broadcasts, err := a.commander.Store().SearchBroadcasts(query, limit)
280+ if err != nil {
281+ return nil, err
282+ }
283+
284+ results := make([]mcp.BroadcastResult, len(broadcasts))
285+ for i, b := range broadcasts {
286+ results[i] = mcp.BroadcastResult{
287+ Content: b.Content,
288+ CreatedAt: b.CreatedAt.Format("2006-01-02 15:04:05"),
289+ }
290+ }
291+ return results, nil
251292 }
252293
253294 // runMCPTest tests the MCP connection and tool calling.
@@ -377,10 +418,18 @@ func (m *mockOrchestrator) MaxAgents() int {
377418 return 16
378419 }
379420
380-func (m *mockOrchestrator) SendMessage(agentID, message string) error {
421+func (m *mockOrchestrator) SendMessageAsync(agentID, message string) error {
381422 return fmt.Errorf("not available in test mode")
382423 }
383424
384-func (m *mockOrchestrator) Broadcast(message string) error {
425+func (m *mockOrchestrator) BroadcastAsync(message string) error {
385426 return fmt.Errorf("not available in test mode")
386427 }
428+
429+func (m *mockOrchestrator) SearchMessages(agentID, query string, limit int) ([]mcp.SearchResult, error) {
430+ return []mcp.SearchResult{}, nil
431+}
432+
433+func (m *mockOrchestrator) SearchBroadcasts(query string, limit int) ([]mcp.BroadcastResult, error) {
434+ return []mcp.BroadcastResult{}, nil
435+}
internal/config/config.go+2−10
@@ -18,8 +18,7 @@ type Config struct {
1818
1919 // SwarmConfig holds swarm-related settings.
2020 type SwarmConfig struct {
21- DefaultAgents int `toml:"default_agents"`
22- MaxAgents int `toml:"max_agents"`
21+ MaxAgents int `toml:"max_agents"`
2322 }
2423
2524 // ProviderConfig holds LLM provider settings.
@@ -37,8 +36,7 @@ type MCPConfig struct {
3736 func DefaultConfig() *Config {
3837 return &Config{
3938 Swarm: SwarmConfig{
40- DefaultAgents: 4,
41- MaxAgents: 16,
39+ MaxAgents: 16,
4240 },
4341 Providers: map[string]ProviderConfig{
4442 "ollama": {
@@ -73,12 +71,6 @@ func Load(path string) (*Config, error) {
7371
7472 // applyEnvOverrides applies environment variable overrides to the configuration.
7573 func applyEnvOverrides(cfg *Config) {
76- if v := os.Getenv("ZOEA_DEFAULT_AGENTS"); v != "" {
77- if n, err := strconv.Atoi(v); err == nil {
78- cfg.Swarm.DefaultAgents = n
79- }
80- }
81-
8274 if v := os.Getenv("ZOEA_MAX_AGENTS"); v != "" {
8375 if n, err := strconv.Atoi(v); err == nil {
8476 cfg.Swarm.MaxAgents = n
internal/config/config_test.go+2−14
@@ -9,9 +9,6 @@ import (
99 func TestDefaultConfig(t *testing.T) {
1010 cfg := DefaultConfig()
1111
12- if cfg.Swarm.DefaultAgents != 4 {
13- t.Errorf("expected default_agents=4, got %d", cfg.Swarm.DefaultAgents)
14- }
1512 if cfg.Swarm.MaxAgents != 16 {
1613 t.Errorf("expected max_agents=16, got %d", cfg.Swarm.MaxAgents)
1714 }
@@ -27,7 +24,6 @@ func TestLoadFromFile(t *testing.T) {
2724
2825 content := `
2926 [swarm]
30-default_agents = 8
3127 max_agents = 32
3228
3329 [providers.ollama]
@@ -46,9 +42,6 @@ upstream = "https://custom.mcp/endpoint"
4642 t.Fatalf("Load() error: %v", err)
4743 }
4844
49- if cfg.Swarm.DefaultAgents != 8 {
50- t.Errorf("expected default_agents=8, got %d", cfg.Swarm.DefaultAgents)
51- }
5245 if cfg.Swarm.MaxAgents != 32 {
5346 t.Errorf("expected max_agents=32, got %d", cfg.Swarm.MaxAgents)
5447 }
@@ -62,11 +55,9 @@ upstream = "https://custom.mcp/endpoint"
6255
6356 func TestLoadWithEnvOverrides(t *testing.T) {
6457 // Set env vars
65- os.Setenv("ZOEA_DEFAULT_AGENTS", "2")
6658 os.Setenv("ZOEA_MAX_AGENTS", "10")
6759 os.Setenv("ZOEA_MCP_ENDPOINT", "https://env.mcp/endpoint")
6860 defer func() {
69- os.Unsetenv("ZOEA_DEFAULT_AGENTS")
7061 os.Unsetenv("ZOEA_MAX_AGENTS")
7162 os.Unsetenv("ZOEA_MCP_ENDPOINT")
7263 }()
@@ -76,9 +67,6 @@ func TestLoadWithEnvOverrides(t *testing.T) {
7667 t.Fatalf("Load() error: %v", err)
7768 }
7869
79- if cfg.Swarm.DefaultAgents != 2 {
80- t.Errorf("expected env override default_agents=2, got %d", cfg.Swarm.DefaultAgents)
81- }
8270 if cfg.Swarm.MaxAgents != 10 {
8371 t.Errorf("expected env override max_agents=10, got %d", cfg.Swarm.MaxAgents)
8472 }
@@ -94,8 +82,8 @@ func TestLoadNonExistentFile(t *testing.T) {
9482 }
9583
9684 // Should return defaults
97- if cfg.Swarm.DefaultAgents != 4 {
98- t.Errorf("expected default_agents=4, got %d", cfg.Swarm.DefaultAgents)
85+ if cfg.Swarm.MaxAgents != 16 {
86+ t.Errorf("expected max_agents=16, got %d", cfg.Swarm.MaxAgents)
9987 }
10088 }