@@ -1,6 +1,8 @@
11 package core
22
33 import (
4+ "errors"
5+ "path/filepath"
46 "testing"
57 "time"
68
@@ -11,9 +13,11 @@ import (
1113 func setupAgentTest(t *testing.T) (*store.Store, *EventBus, func()) {
1214 t.Helper()
1315
14- s, err := store.OpenMemory()
16+ tmpDir := t.TempDir()
17+ dbPath := filepath.Join(tmpDir, "test.db")
18+ s, err := store.Open(dbPath)
1519 if err != nil {
16- t.Fatalf("OpenMemory() error: %v", err)
20+ t.Fatalf("Open() error: %v", err)
1721 }
1822
1923 bus := NewEventBus(100)
@@ -96,18 +100,32 @@ func TestAgentSendMessage(t *testing.T) {
96100 // Subscribe to events
97101 events := bus.Subscribe()
98102
103+ // Wait for the initial autonomous turn to finish
104+ // It should emit a response event for the ContinuePrompt
105+ timeout := time.After(2 * time.Second)
106+initialTurnLoop:
107+ for {
108+ select {
109+ case e := <-events:
110+ if e.Type == EventAgentResponse {
111+ break initialTurnLoop
112+ }
113+ case <-timeout:
114+ t.Fatal("timeout waiting for initial autonomous turn")
115+ }
116+ }
117+
99118 // Send message
100119 if err := agent.SendMessage("Hello, agent!", store.MemorySourceDirect); err != nil {
101120 t.Fatalf("SendMessage() error: %v", err)
102121 }
103122
104- // Should receive message and response events
105- // Also receives network events (LLM start, idle)
123+ // Should receive message and response events for our message
106124 var messageEvent, responseEvent bool
107- timeout := time.After(500 * time.Millisecond)
125+ timeout = time.After(2 * time.Second)
108126
109127 eventLoop:
110- for i := 0; i < 10; i++ { // Allow for all events including network events
128+ for {
111129 select {
112130 case e := <-events:
113131 if e.Type == EventAgentMessage {
@@ -117,10 +135,9 @@ eventLoop:
117135 }
118136 }
119137 if e.Type == EventAgentResponse {
120- responseEvent = true
121138 data := e.Data.(MessageData)
122- if data.Content != "I received your message!" {
123- t.Errorf("expected response 'I received your message!', got %s", data.Content)
139+ if data.Content == "I received your message!" {
140+ responseEvent = true
124141 }
125142 }
126143 // Break early if we have both events
@@ -133,21 +150,67 @@ eventLoop:
133150 }
134151
135152 if !messageEvent {
136- t.Error("expected message event")
153+ t.Error("expected message event for 'Hello, agent!'")
137154 }
138155 if !responseEvent {
139- t.Error("expected response event")
156+ t.Error("expected response event for 'I received your message!'")
140157 }
141158
142159 // Check memories were stored
143- memories, _ := s.GetMemories(stored.ID)
144- if len(memories) != 3 { // system prompt + user + assistant
145- t.Errorf("expected 3 memories, got %d", len(memories))
160+ // Expected: system prompt, continue prompt (initial trigger), assistant response (initial),
161+ // user message, assistant response
162+ memories, err := s.GetMemories(stored.ID)
163+ if err != nil {
164+ t.Fatalf("GetMemories() error: %v", err)
165+ }
166+ if len(memories) != 5 {
167+ t.Errorf("expected 5 memories, got %d", len(memories))
146168 }
147169
148170 agent.Stop()
149171 }
150172
173+func TestAgentSetErrorState(t *testing.T) {
174+ s, bus, cleanup := setupAgentTest(t)
175+ defer cleanup()
176+
177+ stored, _ := s.CreateAgent("error-state-test", "mock", "test-model")
178+ mock := provider.NewMock("mock", "response")
179+ agent := NewAgent(stored.ID, stored.Name, stored.CreatedAt, mock, s, bus)
180+
181+ events := bus.Subscribe()
182+
183+ testErr := errors.New("test error")
184+ agent.setErrorState(testErr)
185+
186+ if agent.State() != AgentStateErrored {
187+ t.Errorf("expected state=errored, got %s", agent.State())
188+ }
189+ if agent.LastError() != testErr {
190+ t.Errorf("expected last error %v, got %v", testErr, agent.LastError())
191+ }
192+
193+ // Should receive state change event first
194+ select {
195+ case e := <-events:
196+ if e.Type != EventAgentStateChanged {
197+ t.Errorf("expected EventAgentStateChanged, got %s", e.Type)
198+ }
199+ case <-time.After(100 * time.Millisecond):
200+ t.Fatal("timeout waiting for state change event")
201+ }
202+
203+ // Should receive error event
204+ select {
205+ case e := <-events:
206+ if e.Type != EventAgentError {
207+ t.Errorf("expected EventAgentError, got %s", e.Type)
208+ }
209+ case <-time.After(100 * time.Millisecond):
210+ t.Fatal("timeout waiting for error event")
211+ }
212+}
213+
151214 func TestAgentProviderName(t *testing.T) {
152215 s, bus, cleanup := setupAgentTest(t)
153216 defer cleanup()
@@ -198,3 +261,76 @@ func TestAgentStateEvents(t *testing.T) {
198261
199262 agent.Stop()
200263 }
264+
265+func TestAgentContextMemoryLimit(t *testing.T) {
266+ s, bus, cleanup := setupAgentTest(t)
267+ defer cleanup()
268+
269+ stored, _ := s.CreateAgent("context-test", "mock", "test-model")
270+ mock := provider.NewMock("mock", "response")
271+ agent := NewAgent(stored.ID, stored.Name, stored.CreatedAt, mock, s, bus)
272+
273+ // Add system prompt
274+ s.AddMemory(stored.ID, store.MemoryRoleSystem, store.MemorySourceSystem, "System prompt")
275+
276+ // Add more memories than MaxContextMessages
277+ for i := 0; i < MaxContextMessages+10; i++ {
278+ s.AddMemory(stored.ID, store.MemoryRoleUser, store.MemorySourceDirect, "user message")
279+ s.AddMemory(stored.ID, store.MemoryRoleAssistant, store.MemorySourceLLM, "assistant response")
280+ }
281+
282+ // Get context memories
283+ memories, err := agent.getContextMemories()
284+ if err != nil {
285+ t.Fatalf("getContextMemories() error: %v", err)
286+ }
287+
288+ // Should have system prompt + MaxContextMessages recent messages
289+ expectedCount := MaxContextMessages + 1 // +1 for system prompt
290+ if len(memories) != expectedCount {
291+ t.Errorf("expected %d memories, got %d", expectedCount, len(memories))
292+ }
293+
294+ // First memory should be system prompt
295+ if memories[0].Role != store.MemoryRoleSystem {
296+ t.Errorf("expected first memory to be system prompt, got %s", memories[0].Role)
297+ }
298+ if memories[0].Content != "System prompt" {
299+ t.Errorf("expected system prompt content, got %s", memories[0].Content)
300+ }
301+}
302+
303+func TestAgentContextMemoryWithRecentSystemPrompt(t *testing.T) {
304+ s, bus, cleanup := setupAgentTest(t)
305+ defer cleanup()
306+
307+ stored, _ := s.CreateAgent("context-test-2", "mock", "test-model")
308+ mock := provider.NewMock("mock", "response")
309+ agent := NewAgent(stored.ID, stored.Name, stored.CreatedAt, mock, s, bus)
310+
311+ // Add system prompt
312+ s.AddMemory(stored.ID, store.MemoryRoleSystem, store.MemorySourceSystem, "System prompt")
313+
314+ // Add fewer memories than MaxContextMessages
315+ for i := 0; i < 5; i++ {
316+ s.AddMemory(stored.ID, store.MemoryRoleUser, store.MemorySourceDirect, "user message")
317+ s.AddMemory(stored.ID, store.MemoryRoleAssistant, store.MemorySourceLLM, "assistant response")
318+ }
319+
320+ // Get context memories
321+ memories, err := agent.getContextMemories()
322+ if err != nil {
323+ t.Fatalf("getContextMemories() error: %v", err)
324+ }
325+
326+ // Should have all memories (system + 10 messages)
327+ expectedCount := 11 // 1 system + 5*2 messages
328+ if len(memories) != expectedCount {
329+ t.Errorf("expected %d memories, got %d", expectedCount, len(memories))
330+ }
331+
332+ // First memory should still be system prompt
333+ if memories[0].Role != store.MemoryRoleSystem {
334+ t.Errorf("expected first memory to be system prompt, got %s", memories[0].Role)
335+ }
336+}