xonecas.io
366
Hc

hirenimble-challenge / commit f297689

Code refactor and cleanup

xonecas2020-08-31 f297689abd15943c4acbfd1b6ea51fc9a92d5098 parent 3a0ca22

4 files changed

src/components/applicationDetais.js+38−0
@@ -0,0 +1,38 @@
1+import React from "react";
2+import { Modal, Title, Body } from "../ui-kit/Modal";
3+import { roleStatuses } from "../utils/enums";
4+
5+function ApplicationDetails(props) {
6+ const {
7+ candidate,
8+ application,
9+ visibility,
10+ modalIsOpen,
11+ toggleModal,
12+ } = props;
13+
14+ const roleStatus = roleStatuses().filter((status) => {
15+ return status.key === application.role.status;
16+ })[0].label;
17+
18+ return (
19+ <React.Fragment key={application.id}>
20+ <div className={visibility ? "d-block" : "d-none"} onClick={toggleModal}>
21+ {application.role.title} {application.new_status.label}
22+ </div>
23+ <Modal isOpen={modalIsOpen} onClose={toggleModal}>
24+ <Title>
25+ <h1>
26+ {candidate.name}, {application.role.title}
27+ </h1>
28+ </Title>
29+ <Body>
30+ <p>Application status: {application.new_status.label}</p>
31+ <p>Role status: {roleStatus}</p>
32+ </Body>
33+ </Modal>
34+ </React.Fragment>
35+ );
36+}
37+
38+export default ApplicationDetails;
src/components/candidateListItem.js+17−14
@@ -1,6 +1,6 @@
11 import React, { useState } from "react";
22 import moment from "moment";
3-import { Modal } from "../ui-kit/Modal";
3+import ApplicationDetail from "./applicationDetais";
44
55 function CandidateListItem(props) {
66 const candidate = props.candidate;
@@ -29,22 +29,25 @@ function CandidateListItem(props) {
2929 <td>{candidate.profile.nimble_score}</td>
3030 <td>{candidate.note_count}</td>
3131 </tr>
32- {candidate.applications.map((application) => {
33- return (
34- <React.Fragment key={application.id}>
35- <tr
32+ <tr>
33+ {candidate.applications.map((application) => {
34+ return (
35+ <td
36+ key={application.id}
3637 className={visibility ? "d-table-row" : "d-none"}
3738 onClick={toggleModal}
3839 >
39- <td>{application.role.title}</td>
40- <td>{application.new_status.label}</td>
41- </tr>
42- <Modal isOpen={modalIsOpen} onClose={toggleModal}>
43- {JSON.stringify(application)}
44- </Modal>
45- </React.Fragment>
46- );
47- })}
40+ <ApplicationDetail
41+ candidate={candidate}
42+ application={application}
43+ visibility={visibility}
44+ modalIsOpen={modalIsOpen}
45+ toggleModal={toggleModal}
46+ ></ApplicationDetail>
47+ </td>
48+ );
49+ })}
50+ </tr>
4851 </React.Fragment>
4952 );
5053 }
src/components/candidatesList.js+1−5
@@ -1,12 +1,8 @@
1-import React, { useState } from "react";
1+import React from "react";
22 import CandidateListItem from "./candidateListItem";
3-import Modal from "../ui-kit/BaseModal";
43
54 function CandidatesList(props) {
6- console.log(props);
7-
85 const candidates = props.candidates.results;
9- const [modalIsOpen, setModalIsOpen] = useState(false);
106
117 return (
128 <table className="table">
src/index.css+3−3
@@ -1,13 +1,13 @@
11 body {
22 margin: 0;
3- font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', 'Roboto', 'Oxygen',
4- 'Ubuntu', 'Cantarell', 'Fira Sans', 'Droid Sans', 'Helvetica Neue',
3+ font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen",
4+ "Ubuntu", "Cantarell", "Fira Sans", "Droid Sans", "Helvetica Neue",
55 sans-serif;
66 -webkit-font-smoothing: antialiased;
77 -moz-osx-font-smoothing: grayscale;
88 }
99
1010 code {
11- font-family: source-code-pro, Menlo, Monaco, Consolas, 'Courier New',
11+ font-family: source-code-pro, Menlo, Monaco, Consolas, "Courier New",
1212 monospace;
1313 }