@@ -2,6 +2,7 @@ package provider
22
33 import (
44 "encoding/json"
5+ "strings"
56 "testing"
67
78 openai "github.com/sashabaranov/go-openai"
@@ -98,8 +99,51 @@ func TestMergeSystemMessagesOpenAI_NoSystemMessages(t *testing.T) {
9899 }
99100 }
100101
101-// TestMergeSystemMessagesOpenAI_Empty tests empty input.
102-func TestMergeSystemMessagesOpenAI_Empty(t *testing.T) {
102+// TestMergeSystemMessagesOpenAI_PreservesConversation tests that conversation
103+// messages are preserved when system messages are merged.
104+func TestMergeSystemMessagesOpenAI_PreservesConversation(t *testing.T) {
105+ messages := []openai.ChatCompletionMessage{
106+ {Role: "system", Content: "System 1"},
107+ {Role: "user", Content: "Hello"},
108+ {Role: "assistant", Content: "Hi there"},
109+ {Role: "system", Content: "System 2"},
110+ {Role: "user", Content: "How are you?"},
111+ {Role: "assistant", Content: "I'm good"},
112+ }
113+
114+ result := mergeSystemMessagesOpenAI(messages)
115+
116+ // Should have: 1 system (merged) + 4 conversation messages = 5 total
117+ if len(result) != 5 {
118+ t.Errorf("expected 5 messages, got %d", len(result))
119+ }
120+
121+ // First should be merged system
122+ if result[0].Role != "system" {
123+ t.Errorf("expected first message to be system, got %s", result[0].Role)
124+ }
125+ expected := "System 1\n\nSystem 2"
126+ if result[0].Content != expected {
127+ t.Errorf("expected content=%q, got %q", expected, result[0].Content)
128+ }
129+
130+ // Rest should be conversation in order
131+ if result[1].Role != "user" || result[1].Content != "Hello" {
132+ t.Errorf("user message 1 not preserved, got role=%s content=%q", result[1].Role, result[1].Content)
133+ }
134+ if result[2].Role != "assistant" || result[2].Content != "Hi there" {
135+ t.Errorf("assistant message 1 not preserved, got role=%s content=%q", result[2].Role, result[2].Content)
136+ }
137+ if result[3].Role != "user" || result[3].Content != "How are you?" {
138+ t.Errorf("user message 2 not preserved, got role=%s content=%q", result[3].Role, result[3].Content)
139+ }
140+ if result[4].Role != "assistant" || result[4].Content != "I'm good" {
141+ t.Errorf("assistant message 2 not preserved, got role=%s content=%q", result[4].Role, result[4].Content)
142+ }
143+}
144+
145+// TestMergeSystemMessagesOpenAI_EmptyInput tests empty input.
146+func TestMergeSystemMessagesOpenAI_EmptyInput(t *testing.T) {
103147 messages := []openai.ChatCompletionMessage{}
104148
105149 result := mergeSystemMessagesOpenAI(messages)
@@ -503,3 +547,60 @@ func TestToOpenAITools_ComplexSchema(t *testing.T) {
503547 t.Errorf("expected tags type=array, got %v", tagsProp["type"])
504548 }
505549 }
550+
551+// TestValidateOpenAIMessages_Valid tests validation passes for valid conversation.
552+func TestValidateOpenAIMessages_Valid(t *testing.T) {
553+ messages := []openai.ChatCompletionMessage{
554+ {Role: "system", Content: "System"},
555+ {Role: "user", Content: "Hello"},
556+ {Role: "assistant", Content: "Hi"},
557+ }
558+
559+ err := validateOpenAIMessages(messages)
560+ if err != nil {
561+ t.Errorf("Expected no error, got: %v", err)
562+ }
563+}
564+
565+// TestValidateOpenAIMessages_EmptyArray tests validation fails for empty messages array.
566+func TestValidateOpenAIMessages_EmptyArray(t *testing.T) {
567+ messages := []openai.ChatCompletionMessage{}
568+
569+ err := validateOpenAIMessages(messages)
570+ if err == nil {
571+ t.Error("Expected error for empty messages array")
572+ }
573+ if !strings.Contains(err.Error(), "empty") {
574+ t.Errorf("Expected 'empty' error, got: %v", err)
575+ }
576+}
577+
578+// TestValidateOpenAIMessages_AssistantWithoutUser tests validation fails for assistant without user message.
579+func TestValidateOpenAIMessages_AssistantWithoutUser(t *testing.T) {
580+ messages := []openai.ChatCompletionMessage{
581+ {Role: "system", Content: "System"},
582+ {Role: "assistant", Content: "Hi"},
583+ }
584+
585+ err := validateOpenAIMessages(messages)
586+ if err == nil {
587+ t.Error("Expected error for assistant without user message")
588+ }
589+ if !strings.Contains(err.Error(), "assistant") || !strings.Contains(err.Error(), "user") {
590+ t.Errorf("Expected assistant/user error, got: %v", err)
591+ }
592+}
593+
594+// TestValidateOpenAIMessages_OnlySystemMessages tests validation passes for only system messages.
595+func TestValidateOpenAIMessages_OnlySystemMessages(t *testing.T) {
596+ messages := []openai.ChatCompletionMessage{
597+ {Role: "system", Content: "System 1"},
598+ {Role: "system", Content: "System 2"},
599+ }
600+
601+ // Only system messages is valid (but will trigger fallback user message in merging)
602+ err := validateOpenAIMessages(messages)
603+ if err != nil {
604+ t.Errorf("Expected no error for only system messages, got: %v", err)
605+ }
606+}