xonecas.io
60255
Zn

Zoea-Nova / commit a1a957c

fix(store): harden broadcast timestamp parsing

Parse multiple layouts and log parse failures to keep broadcast times reliable.

xonecas2026-02-05 a1a957ca7dd994c86fbf0684ba393bf385714500 parent 4b55c8e

2 files changed

internal/store/memories.go+36−8
@@ -3,7 +3,10 @@ package store
33 import (
44 "database/sql"
55 "fmt"
6+ "strconv"
67 "time"
8+
9+ "github.com/rs/zerolog/log"
710 )
811
912 // MemoryRole represents the role in a conversation.
@@ -156,6 +159,27 @@ type BroadcastMessage struct {
156159 CreatedAt time.Time
157160 }
158161
162+var broadcastTimeLayouts = []string{
163+ "2006-01-02 15:04:05.999999999 -0700 MST",
164+ time.RFC3339Nano,
165+ "2006-01-02 15:04:05.999999999",
166+ "2006-01-02 15:04:05",
167+}
168+
169+func parseBroadcastTime(value string) (time.Time, error) {
170+ for _, layout := range broadcastTimeLayouts {
171+ if parsed, err := time.Parse(layout, value); err == nil {
172+ return parsed, nil
173+ }
174+ }
175+
176+ if unixSeconds, err := strconv.ParseInt(value, 10, 64); err == nil {
177+ return time.Unix(unixSeconds, 0).UTC(), nil
178+ }
179+
180+ return time.Time{}, fmt.Errorf("parse broadcast time: %q", value)
181+}
182+
159183 // GetRecentBroadcasts retrieves the most recent N unique broadcast messages.
160184 // Since broadcasts are stored per-mysis, this groups by content to get unique messages.
161185 func (s *Store) GetRecentBroadcasts(limit int) ([]*BroadcastMessage, error) {
@@ -179,11 +203,12 @@ func (s *Store) GetRecentBroadcasts(limit int) ([]*BroadcastMessage, error) {
179203 if err := rows.Scan(&senderID, &content, &createdAtStr); err != nil {
180204 return nil, fmt.Errorf("scan broadcast: %w", err)
181205 }
182- // Parse the time string (SQLite returns aggregated times as strings)
183- createdAt, _ := time.Parse("2006-01-02 15:04:05.999999999 -0700 MST", createdAtStr)
184- if createdAt.IsZero() {
185- // Try alternate format
186- createdAt, _ = time.Parse(time.RFC3339Nano, createdAtStr)
206+ createdAt, err := parseBroadcastTime(createdAtStr)
207+ if err != nil {
208+ log.Warn().
209+ Err(err).
210+ Str("created_at", createdAtStr).
211+ Msg("failed to parse broadcast time")
187212 }
188213 message := &BroadcastMessage{
189214 Content: content,
@@ -295,9 +320,12 @@ func (s *Store) SearchBroadcasts(query string, limit int) ([]*BroadcastMessage,
295320 if err := rows.Scan(&senderID, &content, &createdAtStr); err != nil {
296321 return nil, fmt.Errorf("scan broadcast: %w", err)
297322 }
298- createdAt, _ := time.Parse("2006-01-02 15:04:05.999999999 -0700 MST", createdAtStr)
299- if createdAt.IsZero() {
300- createdAt, _ = time.Parse(time.RFC3339Nano, createdAtStr)
323+ createdAt, err := parseBroadcastTime(createdAtStr)
324+ if err != nil {
325+ log.Warn().
326+ Err(err).
327+ Str("created_at", createdAtStr).
328+ Msg("failed to parse broadcast time")
301329 }
302330 message := &BroadcastMessage{
303331 Content: content,
internal/store/memories_test.go+5−0
@@ -142,6 +142,11 @@ func TestGetRecentBroadcasts(t *testing.T) {
142142 if len(results) != 2 {
143143 t.Errorf("expected 2 results, got %d", len(results))
144144 }
145+ for _, result := range results {
146+ if result.CreatedAt.IsZero() {
147+ t.Fatal("expected broadcast CreatedAt to be parsed")
148+ }
149+ }
145150 // Should be B2, B3 (most recent)
146151 if results[0].Content != "B2" {
147152 t.Errorf("expected B2, got %s", results[0].Content)