@@ -762,40 +762,6 @@ func TestExtractLatestToolLoopHelper(t *testing.T) {
762762 }
763763 }
764764
765-func TestMysisContextCompactionNonSnapshot(t *testing.T) {
766- t.Skip("Obsolete: Tests old non-snapshot compaction. Loop composition doesn't use compaction.")
767- s, bus, cleanup := setupMysisTest(t)
768- defer cleanup()
769-
770- stored, _ := s.CreateMysis("compaction-non-snapshot", "mock", "test-model", 0.7)
771- mock := provider.NewMock("mock", "response")
772- mysis := NewMysis(stored.ID, stored.Name, stored.CreatedAt, mock, s, bus)
773-
774- s.AddMemory(stored.ID, store.MemoryRoleSystem, store.MemorySourceSystem, "System prompt", "", "")
775-
776- for i := 0; i < 2; i++ {
777- s.AddMemory(stored.ID, store.MemoryRoleUser, store.MemorySourceDirect, "travel", "", "")
778- s.AddMemory(stored.ID, store.MemoryRoleAssistant, store.MemorySourceLLM, fmt.Sprintf("[TOOL_CALLS]call_%d:travel:{}", i), "", "")
779- s.AddMemory(stored.ID, store.MemoryRoleTool, store.MemorySourceTool, fmt.Sprintf(`call_%d:{"ship_id":"ship_%d"}`, i, i), "", "")
780- }
781-
782- memories, err := mysis.getContextMemories()
783- if err != nil {
784- t.Fatalf("getContextMemories() error: %v", err)
785- }
786-
787- shipResults := 0
788- for _, m := range memories {
789- if m.Role == store.MemoryRoleTool && strings.Contains(m.Content, `"ship_id"`) {
790- shipResults++
791- }
792- }
793-
794- if shipResults != 2 {
795- t.Fatalf("expected 2 travel results to be kept, got %d", shipResults)
796- }
797-}
798-
799765 func TestComputeMemoryStats(t *testing.T) {
800766 m := &Mysis{}
801767
@@ -2225,12 +2191,15 @@ func TestBuildSystemPrompt_EdgeCases(t *testing.T) {
22252191 })
22262192
22272193 t.Run("broadcast_with_unknown_sender", func(t *testing.T) {
2228- stored, _ := s.CreateMysis("unknown-sender", "mock", "test-model", 0.7)
2194+ stored, _ := s.CreateMysis("receiver-mysis", "mock", "test-model", 0.7)
22292195 mock := provider.NewMock("mock", "response")
22302196 mysis := NewMysis(stored.ID, stored.Name, stored.CreatedAt, mock, s, bus)
22312197
2232- // Add a broadcast with a non-existent sender ID
2233- s.AddMemory("nonexistent-mysis-id", store.MemoryRoleUser, store.MemorySourceBroadcast, "Test broadcast", "", "nonexistent-mysis-id")
2198+ // Add a broadcast with a sender ID that will be deleted (becomes "unknown")
2199+ sender, _ := s.CreateMysis("temp-sender", "mock", "test-model", 0.7)
2200+ s.AddMemory(stored.ID, store.MemoryRoleUser, store.MemorySourceBroadcast, "Test broadcast", "", sender.ID)
2201+ // Delete the sender so it becomes "Unknown"
2202+ s.DeleteMysis(sender.ID)
22342203
22352204 prompt := mysis.buildSystemPrompt()
22362205
@@ -2266,3 +2235,99 @@ func TestBuildSystemPrompt_EdgeCases(t *testing.T) {
22662235 }
22672236 })
22682237 }
2238+// TestSendEphemeralMessage_ErroredState tests sending ephemeral message to errored mysis.
2239+func TestSendEphemeralMessage_ErroredState(t *testing.T) {
2240+ s, bus, cleanup := setupMysisTest(t)
2241+ defer cleanup()
2242+
2243+ stored, err := s.CreateMysis("errored-mysis", "mock", "test-model", 0.7)
2244+ if err != nil {
2245+ t.Fatalf("CreateMysis() error: %v", err)
2246+ }
2247+
2248+ mock := provider.NewMock("mock", "response")
2249+ mysis := NewMysis(stored.ID, stored.Name, stored.CreatedAt, mock, s, bus)
2250+
2251+ // Set mysis to errored state
2252+ mysis.mu.Lock()
2253+ mysis.state = MysisStateErrored
2254+ mysis.mu.Unlock()
2255+
2256+ // Attempt to send ephemeral message
2257+ err = mysis.SendEphemeralMessage("Test message", store.MemorySourceDirect)
2258+
2259+ if err == nil {
2260+ t.Fatal("expected error when sending to errored mysis")
2261+ }
2262+
2263+ expectedErrMsg := "mysis errored - press 'r' to relaunch"
2264+ if !strings.Contains(err.Error(), expectedErrMsg) {
2265+ t.Errorf("expected error containing %q, got: %v", expectedErrMsg, err)
2266+ }
2267+}
2268+
2269+// TestSendEphemeralMessage_EmptyContent tests sending empty ephemeral message.
2270+func TestSendEphemeralMessage_EmptyContent(t *testing.T) {
2271+ s, bus, cleanup := setupMysisTest(t)
2272+ defer cleanup()
2273+
2274+ stored, err := s.CreateMysis("test-mysis", "mock", "test-model", 0.7)
2275+ if err != nil {
2276+ t.Fatalf("CreateMysis() error: %v", err)
2277+ }
2278+
2279+ mock := provider.NewMock("mock", "response")
2280+ mysis := NewMysis(stored.ID, stored.Name, stored.CreatedAt, mock, s, bus)
2281+
2282+ // Send empty ephemeral message (should be allowed - LLM can handle it)
2283+ err = mysis.SendEphemeralMessage("", store.MemorySourceDirect)
2284+
2285+ // Empty content should not cause an error - the LLM will receive it
2286+ if err != nil {
2287+ t.Errorf("unexpected error for empty content: %v", err)
2288+ }
2289+}
2290+
2291+// TestSendEphemeralMessage_MCPListToolsError tests handling of MCP tool listing errors.
2292+func TestSendEphemeralMessage_MCPListToolsError(t *testing.T) {
2293+ s, bus, cleanup := setupMysisTest(t)
2294+ defer cleanup()
2295+
2296+ stored, err := s.CreateMysis("test-mysis", "mock", "test-model", 0.7)
2297+ if err != nil {
2298+ t.Fatalf("CreateMysis() error: %v", err)
2299+ }
2300+
2301+ // Use a mock provider that returns quickly
2302+ mock := provider.NewMock("mock", "response")
2303+
2304+ // Create a failing MCP proxy
2305+ failingMCP := &mcp.FailingMockClient{Err: errors.New("connection refused")}
2306+
2307+ mysis := NewMysis(stored.ID, stored.Name, stored.CreatedAt, mock, s, bus)
2308+ mysis.mcp = failingMCP
2309+
2310+ // Send ephemeral message - should handle MCP error gracefully
2311+ err = mysis.SendEphemeralMessage("Test", store.MemorySourceDirect)
2312+
2313+ // Should complete successfully even with MCP error (continues without tools)
2314+ if err == nil {
2315+ // Wait for async response processing
2316+ time.Sleep(100 * time.Millisecond)
2317+ }
2318+
2319+ // Check that mysis published an error event
2320+ select {
2321+ case event := <-bus.Subscribe():
2322+ if event.Type != EventMysisError {
2323+ t.Errorf("expected EventMysisError, got %v", event.Type)
2324+ }
2325+ if event.Error == nil {
2326+ t.Error("expected error data in event")
2327+ } else if !strings.Contains(event.Error.Error, "Failed to load tools") {
2328+ t.Errorf("expected 'Failed to load tools' error, got: %v", event.Error.Error)
2329+ }
2330+ case <-time.After(1 * time.Second):
2331+ t.Error("timeout waiting for error event")
2332+ }
2333+}