xonecas.io
60255
Zn

Zoea-Nova / commit 4c82dba

fix: implement complete goroutine cleanup on exit

Prevents application from hanging on exit by ensuring all goroutines
terminate cleanly and resources are released in proper order.

Event Bus Cleanup:
- Event bus already closed via onQuit callback before tea.Quit processes
- Added explicit bus.Close() in main cleanup (idempotent)
- Removed redundant StopAll() from signal handler (avoid double-stop)
- Signal handler only closes bus and quits TUI

WaitGroup Tracking:
- Add sync.WaitGroup to Commander to track running mysis goroutines
- Increment WaitGroup in StartMysis before starting
- Decrement WaitGroup in Mysis.run() defer when exiting
- StopAll() now waits for all goroutines with c.wg.Wait()
- Commander reference added to Mysis (optional variadic parameter)

Provider Cleanup:
- Add Close() method to Provider interface
- Ollama and OpenCode providers already implement Close()
- Add Close() to MockProvider (no-op)
- Call provider.Close() in Mysis.Stop() after releasing account

Goroutine Leak Detection:
- Import runtime package
- Log goroutine count at startup
- Log goroutine count during shutdown
- Log final count at exit
- Enables detection of goroutine leaks during testing

Shutdown Sequence:
1. User presses 'q' OR signal received
2. onQuit callback closes event bus (unblocks listener)
3. tea.Quit processed, TUI exits
4. program.Run() returns
5. StopAll() stops all myses, waits for goroutines
6. bus.Close() called (idempotent)
7. Accounts released
8. Store closed (deferred)
9. Log file closed (deferred)

All resources now cleaned up properly without hangs.

Implements: documentation/plans/2026-02-06-goroutine-cleanup-fixes.md
Fixes: GOROUTINE_CLEANUP_ANALYSIS.md issues 1-5

Test status: All tests passing (76.8% core, 85.6% TUI)

xonecas2026-02-06 4c82dba1f4cccbe0c9c7da761306c2359225fafc parent cac04bc

5 files changed

cmd/zoea/main.go+11−2
@@ -7,6 +7,7 @@ import (
77 "os"
88 "os/signal"
99 "path/filepath"
10+ "runtime"
1011 "syscall"
1112 "time"
1213
@@ -147,6 +148,9 @@ func main() {
147148
148149 log.Debug().Bool("upstream", mcpProxy.HasUpstream()).Int("local_tools", mcpProxy.LocalToolCount()).Msg("MCP proxy initialized")
149150
151+ // Log goroutine count at startup for leak detection
152+ log.Info().Int("goroutines", runtime.NumGoroutine()).Msg("Application started")
153+
150154 // Set up signal handling for graceful shutdown
151155 sigCh := make(chan os.Signal, 1)
152156 signal.Notify(sigCh, syscall.SIGINT, syscall.SIGTERM)
@@ -168,7 +172,8 @@ func main() {
168172 go func() {
169173 <-sigCh
170174 log.Info().Msg("Received shutdown signal")
171- commander.StopAll()
175+ // Don't call StopAll here - let main cleanup handle it after program.Run()
176+ // This avoids stopping myses twice
172177 bus.Close() // Close event bus to unblock TUI event listener
173178 program.Quit()
174179 }()
@@ -179,14 +184,18 @@ func main() {
179184 }
180185
181186 // Clean shutdown
187+ log.Info().Int("goroutines", runtime.NumGoroutine()).Msg("Shutdown initiated")
182188 commander.StopAll()
183189
190+ // Close bus (idempotent if already closed by onQuit or signal handler)
191+ bus.Close()
192+
184193 // Release all accounts
185194 if err := s.ReleaseAllAccounts(); err != nil {
186195 log.Warn().Err(err).Msg("Failed to release accounts on shutdown")
187196 }
188197
189- log.Info().Msg("Zoea Nova shutdown complete")
198+ log.Info().Int("goroutines", runtime.NumGoroutine()).Msg("Zoea Nova shutdown complete")
190199 }
191200
192201 func initLogging(debug bool) error {
internal/core/commander.go+13−3
@@ -17,6 +17,7 @@ import (
1717 // Commander orchestrates the swarm of myses.
1818 type Commander struct {
1919 mu sync.RWMutex
20+ wg sync.WaitGroup // Tracks running mysis goroutines
2021
2122 myses map[string]*Mysis
2223 store *store.Store
@@ -68,7 +69,7 @@ func (c *Commander) LoadMyses() error {
6869 continue
6970 }
7071
71- mysis := NewMysis(sm.ID, sm.Name, sm.CreatedAt, p, c.store, c.bus)
72+ mysis := NewMysis(sm.ID, sm.Name, sm.CreatedAt, p, c.store, c.bus, c)
7273 if c.mcp != nil {
7374 mysis.SetMCP(c.mcp)
7475 }
@@ -106,7 +107,7 @@ func (c *Commander) CreateMysis(name, providerName string) (*Mysis, error) {
106107 }
107108
108109 // Create runtime mysis
109- mysis := NewMysis(stored.ID, stored.Name, stored.CreatedAt, p, c.store, c.bus)
110+ mysis := NewMysis(stored.ID, stored.Name, stored.CreatedAt, p, c.store, c.bus, c)
110111 if c.mcp != nil {
111112 mysis.SetMCP(c.mcp)
112113 }
@@ -187,7 +188,13 @@ func (c *Commander) StartMysis(id string) error {
187188 if err != nil {
188189 return err
189190 }
190- return mysis.Start()
191+
192+ c.wg.Add(1) // Track this goroutine
193+ if err := mysis.Start(); err != nil {
194+ c.wg.Done() // Failed to start, don't track
195+ return err
196+ }
197+ return nil
191198 }
192199
193200 // StopMysis stops a mysis by ID.
@@ -368,6 +375,7 @@ func (c *Commander) StopAll() {
368375
369376 done := make(chan struct{})
370377 go func() {
378+ // Stop all running myses
371379 for _, m := range myses {
372380 if m.State() == MysisStateRunning {
373381 if err := m.Stop(); err != nil {
@@ -375,6 +383,8 @@ func (c *Commander) StopAll() {
375383 }
376384 }
377385 }
386+ // Wait for all mysis goroutines to complete
387+ c.wg.Wait()
378388 close(done)
379389 }()
380390
internal/core/mysis.go+19−1
@@ -28,6 +28,7 @@ type Mysis struct {
2828 store *store.Store
2929 bus *EventBus
3030 mcp *mcp.Proxy
31+ commander *Commander // Reference to parent commander for WaitGroup
3132
3233 state MysisState
3334 ctx context.Context
@@ -58,7 +59,11 @@ type contextStats struct {
5859 }
5960
6061 // NewMysis creates a new mysis from stored data.
61-func NewMysis(id, name string, createdAt time.Time, p provider.Provider, s *store.Store, bus *EventBus) *Mysis {
62+func NewMysis(id, name string, createdAt time.Time, p provider.Provider, s *store.Store, bus *EventBus, cmd ...*Commander) *Mysis {
63+ var commander *Commander
64+ if len(cmd) > 0 {
65+ commander = cmd[0]
66+ }
6267 return &Mysis{
6368 id: id,
6469 name: name,
@@ -66,6 +71,7 @@ func NewMysis(id, name string, createdAt time.Time, p provider.Provider, s *stor
6671 provider: p,
6772 store: s,
6873 bus: bus,
74+ commander: commander,
6975 state: MysisStateIdle,
7076 activityState: ActivityStateIdle,
7177 nudgeCh: make(chan struct{}, 1),
@@ -283,6 +289,13 @@ func (m *Mysis) Stop() error {
283289 a.emitStateChange(oldState, MysisStateStopped)
284290 a.releaseCurrentAccount()
285291
292+ // Close provider HTTP client
293+ if a.provider != nil {
294+ if err := a.provider.Close(); err != nil {
295+ log.Warn().Err(err).Str("mysis", a.name).Msg("Failed to close provider")
296+ }
297+ }
298+
286299 return nil
287300 }
288301
@@ -961,6 +974,11 @@ func (m *Mysis) isSnapshotTool(toolName string) bool {
961974 // run is the mysis main processing loop.
962975 func (m *Mysis) run(ctx context.Context) {
963976 a := m
977+ // Signal goroutine completion when exiting
978+ if a.commander != nil {
979+ defer a.commander.wg.Done()
980+ }
981+
964982 // Ticker to nudge the mysis if it's idle
965983 ticker := time.NewTicker(constants.IdleNudgeInterval)
966984 defer ticker.Stop()
internal/provider/mock.go+5−0
@@ -197,3 +197,8 @@ func (p *MockProvider) waitDelay(ctx context.Context) error {
197197 return nil
198198 }
199199 }
200+
201+// Close is a no-op for mock provider (no resources to clean up).
202+func (p *MockProvider) Close() error {
203+ return nil
204+}
internal/provider/provider.go+3−0
@@ -52,6 +52,9 @@ type Provider interface {
5252
5353 // Stream sends messages and returns a channel that streams response chunks.
5454 Stream(ctx context.Context, messages []Message) (<-chan StreamChunk, error)
55+
56+ // Close closes idle HTTP connections and cleans up resources.
57+ Close() error
5558 }
5659
5760 type ProviderFactory interface {