xonecas.io
60255
Zn

Zoea-Nova / commit 134f332

feat: add turn boundary detection with findLastUserPromptIndex

Add findLastUserPromptIndex() function to detect the boundary between
current and historical turns by finding the most recent user-initiated
prompt (direct, broadcast, or system nudge).

This is Phase 1 of the turn-aware context composition plan, which will
enable proper preservation of current turn context when historical
memories need to be included.

Changes:
- Add findLastUserPromptIndex() to internal/core/mysis.go
- Add comprehensive test coverage in internal/core/mysis_test.go
- Test cases cover: direct messages, broadcasts, system nudges, tool
  loops, multiple user messages, and empty memories

All tests pass.

xonecas2026-02-07 134f332cf4c923c77f0bd24fddb76129811e5681 parent 7b77396

2 files changed

internal/core/mysis.go+26−0
@@ -1428,6 +1428,32 @@ func (m *Mysis) extractLatestToolLoop(memories []*store.Memory) []*store.Memory
14281428 return result
14291429 }
14301430
1431+// findLastUserPromptIndex finds the index of the most recent user-initiated prompt.
1432+// User prompts include:
1433+// - Direct messages (source: direct)
1434+// - Broadcasts (source: broadcast)
1435+// - System nudges (source: system, role: user)
1436+//
1437+// Returns -1 if no user prompt is found.
1438+//
1439+// This defines the "current turn" boundary - everything from this index onward
1440+// is part of the current conversation turn and should be included in full context.
1441+func (m *Mysis) findLastUserPromptIndex(memories []*store.Memory) int {
1442+ // Scan backwards to find most recent user prompt
1443+ for i := len(memories) - 1; i >= 0; i-- {
1444+ mem := memories[i]
1445+ if mem.Role == store.MemoryRoleUser {
1446+ // User messages from direct, broadcast, or system (nudges) all count as prompts
1447+ if mem.Source == store.MemorySourceDirect ||
1448+ mem.Source == store.MemorySourceBroadcast ||
1449+ mem.Source == store.MemorySourceSystem {
1450+ return i
1451+ }
1452+ }
1453+ }
1454+ return -1
1455+}
1456+
14311457 // getContextMemories returns memories for LLM context using loop-based composition.
14321458 // Composes context as: [system prompt] + [chosen prompt source] + [most recent tool loop].
14331459 // This ensures stable, bounded context and eliminates orphaned tool sequencing.
internal/core/mysis_test.go+60−0
@@ -1971,3 +1971,63 @@ func TestQueueBroadcast_StoppedState(t *testing.T) {
19711971 t.Errorf("error should mention stopped, got: %v", err)
19721972 }
19731973 }
1974+
1975+func TestFindLastUserPromptIndex(t *testing.T) {
1976+ tests := []struct {
1977+ name string
1978+ memories []*store.Memory
1979+ expected int
1980+ }{
1981+ {
1982+ name: "last message is user",
1983+ memories: []*store.Memory{
1984+ {Role: store.MemoryRoleSystem, Content: "system"},
1985+ {Role: store.MemoryRoleUser, Content: "hello", Source: store.MemorySourceDirect},
1986+ },
1987+ expected: 1,
1988+ },
1989+ {
1990+ name: "user followed by tool loop",
1991+ memories: []*store.Memory{
1992+ {Role: store.MemoryRoleSystem, Content: "system"},
1993+ {Role: store.MemoryRoleUser, Content: "check status", Source: store.MemorySourceDirect},
1994+ {Role: store.MemoryRoleAssistant, Content: "[TOOL_CALLS]call_1:get_status:{}"},
1995+ {Role: store.MemoryRoleTool, Content: "call_1:status data"},
1996+ },
1997+ expected: 1,
1998+ },
1999+ {
2000+ name: "multiple user messages",
2001+ memories: []*store.Memory{
2002+ {Role: store.MemoryRoleUser, Content: "first", Source: store.MemorySourceDirect},
2003+ {Role: store.MemoryRoleAssistant, Content: "response"},
2004+ {Role: store.MemoryRoleUser, Content: "second", Source: store.MemorySourceDirect},
2005+ },
2006+ expected: 2,
2007+ },
2008+ {
2009+ name: "no user messages",
2010+ memories: []*store.Memory{
2011+ {Role: store.MemoryRoleSystem, Content: "system"},
2012+ },
2013+ expected: -1,
2014+ },
2015+ {
2016+ name: "broadcast is user prompt",
2017+ memories: []*store.Memory{
2018+ {Role: store.MemoryRoleUser, Content: "broadcast msg", Source: store.MemorySourceBroadcast},
2019+ },
2020+ expected: 0,
2021+ },
2022+ }
2023+
2024+ for _, tt := range tests {
2025+ t.Run(tt.name, func(t *testing.T) {
2026+ mysis := &Mysis{}
2027+ result := mysis.findLastUserPromptIndex(tt.memories)
2028+ if result != tt.expected {
2029+ t.Errorf("expected %d, got %d", tt.expected, result)
2030+ }
2031+ })
2032+ }
2033+}