xonecas.io
62159
Sy

symb / commit 35372fe

docs: document theme limitations and maybe issues

xonecas2026-02-15 35372fe2127f9415486ba9a8d9110309039db568 parent 33bc9ca

1 file changed

docs/TODO_THEME.md+19−0
@@ -0,0 +1,19 @@
1+# Code Review: `33bc9ca` — Derive UI chrome colors from Chroma syntax theme
2+
3+## Medium: `pickAccent` loop range too small
4+
5+`internal/highlight/highlight.go:187` — The loop `for tt := chroma.TokenType(0); tt < 2000; tt++` only scans token types 0–1999. Chroma's `Name`, `Literal`, `String`, `Operator`, `Comment`, `Generic`, and `Text` tokens all live at 2000+. This means the accent is picked from keyword tokens only, missing the most colorful parts of most themes.
6+
7+**Fix**: Use a range up to ~9000 or iterate `chroma.TokenTypeValues()`.
8+
9+## Low: `pickError` lerp direction contradicts its doc comment
10+
11+`internal/highlight/highlight.go:210-215` — The comment says "lerps 45% toward fg" but the code does `lerpHex(bg, errorColor, 0.45)`, which lerps from bg toward the error color instead. Result is darker than described, though still usable.
12+
13+## Low: `ColorWarning` is now identical to `ColorError`
14+
15+`internal/tui/styles.go:24` — Both map to `palette.Error`. Previously warning was a distinct amber. Comment says intentional, but warnings and errors are now visually indistinguishable.
16+
17+## Trivial: Doc says 60+ entries required, but `github-dark` has 43
18+
19+`internal/constants/constants.go:24` — Documentation inconsistency between the stated threshold and the actual entry count.