xonecas.io
64875
Mc

mini-coder / commit d76b814

refactor: remove showReasoning from StatusBarData and signature

Toggling /reasoning triggered a spurious status bar redraw because
showReasoning was included in buildStatusBarSignature. It was never
rendered in the bar (only used to drive renderTurn), so remove it from
StatusBarData, RunnerStatusInfo, buildStatusBarSignature, and all
callsites. Also clears the Refactors item from KNOWN_ISSUES.

xonecas2026-03-21 d76b8144c2946305d75842fc712f187b733a3221 parent 7147f5b

7 files changed

AUDIT-REPORT.md+1−1
@@ -99,7 +99,7 @@ N/T = Not specifically tested in interactive mode, but one-shot works.
9999
100100 ### Polish
101101
102-4. **Status bar: merge model + thinking effort** (KNOWN) — The `showReasoning` field in the status bar signature contributes to unnecessary re-renders. The known issues already track this.
102+4. ~~**Status bar: `showReasoning` in signature**~~ **FIXED** (`HEAD`) — Removed `showReasoning` from `StatusBarData`, `RunnerStatusInfo`, and `buildStatusBarSignature`. Toggling `/reasoning` no longer triggers a spurious status bar redraw.
103103
104104 5. ~~**Shell tool truncation**~~ **FIXED** (`19a9755`) — Truncation now snaps to the last `\n` in the partial chunk, preventing broken mid-line cuts.
105105
docs/KNOWN_ISSUES.md+0−2
@@ -13,5 +13,3 @@
1313 - Conversation summary on max context instead of just an error with `/new` suggestion.
1414
1515 ## Refactors
16-
17-- Status bar: merge model + thinking effort into one field, drop `showReasoning` (already in banner).
src/agent/reporter.ts+0−1
@@ -19,7 +19,6 @@ export interface StatusBarData {
1919 contextTokens: number;
2020 contextWindow: number | null;
2121 thinkingEffort?: string | null;
22- showReasoning?: boolean;
2322 }
2423
2524 export interface AgentReporter {
src/agent/session-runner.ts+0−2
@@ -45,7 +45,6 @@ interface RunnerStatusInfo {
4545 model: string;
4646 sessionId: string;
4747 thinkingEffort: ThinkingEffort | null;
48- showReasoning: boolean;
4948 totalIn: number;
5049 totalOut: number;
5150 lastContextTokens: number;
@@ -89,7 +88,6 @@ export class SessionRunner {
8988 model: this.currentModel,
9089 sessionId: this.session.id,
9190 thinkingEffort: this.currentThinkingEffort,
92- showReasoning: this.showReasoning,
9391 totalIn: this.totalIn,
9492 totalOut: this.totalOut,
9593 lastContextTokens: this.lastContextTokens,
src/cli/input-loop.ts+0−1
@@ -67,7 +67,6 @@ export async function runInputLoop(opts: InputLoopOptions): Promise<void> {
6767 contextTokens: status.lastContextTokens,
6868 contextWindow,
6969 thinkingEffort: status.thinkingEffort,
70- showReasoning: status.showReasoning,
7170 };
7271 const statusSignature = buildStatusBarSignature(statusData);
7372 if (statusSignature !== lastStatusSignature) {
src/cli/status-bar.test.ts+0−4
@@ -28,7 +28,6 @@ describe("renderStatusBar", () => {
2828 contextTokens: 8000,
2929 contextWindow: 128000,
3030 thinkingEffort: "medium",
31- showReasoning: true,
3231 });
3332 });
3433
@@ -57,7 +56,6 @@ describe("renderStatusBar", () => {
5756 contextTokens: 72000,
5857 contextWindow: 128000,
5958 thinkingEffort: "xhigh",
60- showReasoning: true,
6159 });
6260 });
6361
@@ -84,7 +82,6 @@ describe("renderStatusBar", () => {
8482 contextTokens: 2048,
8583 contextWindow: null,
8684 thinkingEffort: null,
87- showReasoning: false,
8885 });
8986 });
9087
@@ -105,7 +102,6 @@ describe("renderStatusBar", () => {
105102 contextWindow: 100,
106103 thinkingEffort: "medium",
107104 activeAgent: null,
108- showReasoning: false,
109105 } as const;
110106
111107 expect(buildStatusBarSignature(base)).toBe(buildStatusBarSignature(base));
src/cli/status-bar.ts+0−1
@@ -47,7 +47,6 @@ export function buildStatusBarSignature(opts: StatusBarData): string {
4747 contextTokens: opts.contextTokens,
4848 contextWindow: opts.contextWindow,
4949 thinkingEffort: opts.thinkingEffort ?? null,
50- showReasoning: opts.showReasoning ?? false,
5150 });
5251 }