xonecas.io
8058
Ir

irvc / commit fe1eee2

fix: address several minor issues

- font size was not working
- stale settings after toggles
- empty menus where no actions were available

xonecas2026-10-16 fe1eee2bfb9ef5c50dfc00fd342cb4faa12bd787 parent a494d37

5 files changed

web/src/App.tsx+2−9
@@ -7,19 +7,12 @@ import Join from "./views/Join";
77 import Login from "./views/Login";
88 import Chat from "./views/Chat";
99
10-// Text size is a document-level preference, applied on the root element so
11-// every rem-based size follows it.
12-const fontSizes: Record<string, string> = { default: "", normal: "16px", large: "18px" };
13-
1410 export default function App() {
1511 const [user, setUser] = useState<User | null>(null);
1612 const [loading, setLoading] = useState(true);
1713 const [showJoin, setShowJoin] = useState(window.location.pathname === "/join");
18- const { settings } = useSettings();
19-
20- useEffect(() => {
21- document.documentElement.style.fontSize = fontSizes[settings.fontSize] ?? "16px";
22- }, [settings.fontSize]);
14+ // Applied here too so the logged-out screens follow the text size preference.
15+ useSettings();
2316
2417 useEffect(() => {
2518 api<User>("/me")
web/src/components/Sidebar.tsx+8−6
@@ -87,12 +87,14 @@ export default function Sidebar({
8787 badge={unread[c.id]}
8888 active={selected?.id === c.id}
8989 onSelect={() => onSelect(c)}
90- actions={(close) =>
91- !c.permanent && (
92- <MenuItem onClick={() => (close(), onDeleteChannel(c))} danger>
93- delete channel
94- </MenuItem>
95- )
90+ actions={
91+ c.permanent
92+ ? undefined
93+ : (close) => (
94+ <MenuItem onClick={() => (close(), onDeleteChannel(c))} danger>
95+ delete channel
96+ </MenuItem>
97+ )
9698 }
9799 />
98100 ))}
web/src/lib/settings.ts+5−0
@@ -49,6 +49,10 @@ export const defaultSettings: Settings = {
4949
5050 const key = "irvc.settings";
5151
52+// Text size is a document-level preference, applied on the root element so
53+// every rem-based size follows it. "default" leaves the browser's root size.
54+const fontSizes: Record<FontSize, string> = { default: "", normal: "16px", large: "18px" };
55+
5256 function load(): Settings {
5357 try {
5458 return { ...defaultSettings, ...JSON.parse(localStorage.getItem(key) ?? "{}") };
@@ -64,6 +68,7 @@ export function useSettings() {
6468
6569 useEffect(() => {
6670 localStorage.setItem(key, JSON.stringify(settings));
71+ document.documentElement.style.fontSize = fontSizes[settings.fontSize];
6772 }, [settings]);
6873
6974 const update = useCallback((patch: Partial<Settings>) => {
web/src/lib/theme.ts+4−2
@@ -1,4 +1,4 @@
1-import { useCallback, useEffect, useState } from "react";
1+import { useCallback, useEffect, useLayoutEffect, useState } from "react";
22
33 export type Mode = "light" | "dark";
44
@@ -114,7 +114,9 @@ function rgbToHex(color: string) {
114114 export function useTheme() {
115115 const [prefs, setPrefs] = useState<ThemePrefs>(loadPrefs);
116116
117- useEffect(() => {
117+ // Applied before the browser paints so anything reading the computed
118+ // palette (the settings color swatches) sees the new mode immediately.
119+ useLayoutEffect(() => {
118120 applyTheme(prefs);
119121 localStorage.setItem(key, JSON.stringify(prefs));
120122 }, [prefs]);
web/src/views/Settings.tsx+12−4
@@ -1,4 +1,4 @@
1-import { useEffect, useMemo, useRef, useState } from "react";
1+import { useEffect, useRef, useState } from "react";
22 import { Moon, RotateCcw, Sun } from "lucide-react";
33 import { Room } from "livekit-client";
44 import { Button, Field, Section, Select, Toggle } from "@/ui";
@@ -105,7 +105,7 @@ export default function SettingsView({
105105 options={[
106106 { value: "normal", label: "normal" },
107107 { value: "default", label: "browser default" },
108- { value: "large", label: "large" },
108+ { value: "large", label: "Help I'm old" },
109109 ]}
110110 />
111111 </Field>
@@ -117,6 +117,8 @@ export default function SettingsView({
117117 <ColorField
118118 key={t}
119119 token={t}
120+ mode={prefs.mode}
121+ preset={prefs.preset}
120122 override={prefs.overrides[prefs.mode][t]}
121123 onChange={(color) => setToken(t, color)}
122124 />
@@ -231,15 +233,21 @@ export default function SettingsView({
231233
232234 function ColorField({
233235 token,
236+ mode,
237+ preset,
234238 override,
235239 onChange,
236240 }: {
237241 token: Token;
242+ mode: Mode;
243+ preset: PresetId;
238244 override?: string;
239245 onChange: (color: string) => void;
240246 }) {
241- // Re-read the palette whenever anything that feeds it changes.
242- const value = useMemo(() => effective(token), [token, override]);
247+ // Re-read the palette after the theme has been applied to the DOM, so the
248+ // swatch never shows the previous mode's or preset's colors.
249+ const [value, setValue] = useState(() => effective(token));
250+ useEffect(() => setValue(effective(token)), [token, override, mode, preset]);
243251 return (
244252 <label className="flex items-center gap-2 rounded-md px-2 py-1.5 text-sm transition-colors hover:bg-raised">
245253 <input