@@ -121,7 +121,7 @@ describe("TextInput integration", () => {
121121 expect(value).toBe("ab\n");
122122 });
123123
124- test("submitKey fires onSubmit instead of inserting", async () => {
124+ test("onKeyPress returning false prevents default editing action", async () => {
125125 const term = setup(20, 3);
126126 let submitted = false;
127127 let value = "hello";
@@ -133,10 +133,12 @@ describe("TextInput integration", () => {
133133 onChange: (v) => {
134134 value = v;
135135 },
136- onSubmit: () => {
137- submitted = true;
136+ onKeyPress: (key) => {
137+ if (key === "enter") {
138+ submitted = true;
139+ return false;
140+ }
138141 },
139- submitKey: "enter",
140142 }),
141143 ]),
142144 );
@@ -146,12 +148,12 @@ describe("TextInput integration", () => {
146148 await waitForRender();
147149
148150 expect(submitted).toBe(true);
149- expect(value).toBe("hello"); // Value should not change
151+ expect(value).toBe("hello"); // No newline inserted
150152 });
151153
152- test("ctrl+enter as submitKey with enter for newlines", async () => {
154+ test("onKeyPress not returning false allows default editing", async () => {
153155 const term = setup(20, 3);
154- let submitted = false;
156+ let keyReceived = "";
155157 let value = "hi";
156158 cel.viewport(() =>
157159 VStack({}, [
@@ -161,20 +163,150 @@ describe("TextInput integration", () => {
161163 onChange: (v) => {
162164 value = v;
163165 },
164- onSubmit: () => {
165- submitted = true;
166+ onKeyPress: (key) => {
167+ keyReceived = key;
168+ // no return false — default editing proceeds
169+ },
170+ }),
171+ ]),
172+ );
173+ await waitForRender();
174+
175+ term.sendInput(ENTER);
176+ await waitForRender();
177+
178+ expect(keyReceived).toBe("enter");
179+ expect(value).toBe("hi\n"); // Newline inserted
180+ });
181+
182+ test("onKeyPress returning false prevents character insertion", async () => {
183+ const term = setup(20, 3);
184+ let value = "abc";
185+ cel.viewport(() =>
186+ VStack({}, [
187+ TextInput({
188+ value,
189+ focused: true,
190+ onChange: (v) => {
191+ value = v;
192+ },
193+ onKeyPress: (key) => {
194+ if (key === "x") return false;
166195 },
167- submitKey: "ctrl+enter",
168196 }),
169197 ]),
170198 );
171199 await waitForRender();
172200
173- // Enter should insert newline (not submit)
201+ // "x" should be prevented
202+ term.sendInput("x");
203+ await waitForRender();
204+ expect(value).toBe("abc");
205+
206+ // "y" should go through
207+ term.sendInput("y");
208+ await waitForRender();
209+ expect(value).toBe("abcy");
210+ });
211+
212+ test("onKeyPress returning false prevents backspace", async () => {
213+ const term = setup(20, 3);
214+ let value = "abc";
215+ cel.viewport(() =>
216+ VStack({}, [
217+ TextInput({
218+ value,
219+ focused: true,
220+ onChange: (v) => {
221+ value = v;
222+ },
223+ onKeyPress: (key) => {
224+ if (key === "backspace") return false;
225+ },
226+ }),
227+ ]),
228+ );
229+ await waitForRender();
230+
231+ term.sendInput(BACKSPACE);
232+ await waitForRender();
233+
234+ expect(value).toBe("abc"); // No deletion
235+ });
236+
237+ test("onKeyPress on TextInput fires before ancestor onKeyPress", async () => {
238+ const term = setup(20, 3);
239+ let parentKey = "";
240+ let inputKey = "";
241+ let value = "hi";
242+ cel.viewport(() =>
243+ VStack(
244+ {
245+ onKeyPress: (key) => {
246+ parentKey = key;
247+ },
248+ },
249+ [
250+ TextInput({
251+ value,
252+ focused: true,
253+ onChange: (v) => {
254+ value = v;
255+ },
256+ onKeyPress: (key) => {
257+ if (key === "enter") {
258+ inputKey = key;
259+ return false; // prevent default, consume key
260+ }
261+ },
262+ }),
263+ ],
264+ ),
265+ );
266+ await waitForRender();
267+
174268 term.sendInput(ENTER);
175269 await waitForRender();
176- expect(value).toBe("hi\n");
177- expect(submitted).toBe(false);
270+
271+ expect(inputKey).toBe("enter");
272+ expect(parentKey).toBe(""); // Ancestor never sees it
273+ expect(value).toBe("hi"); // No newline
274+ });
275+
276+ test("non-editing key bubbles to ancestor when onKeyPress doesn't intercept", async () => {
277+ const term = setup(20, 3);
278+ let parentKey = "";
279+ let value = "hi";
280+ cel.viewport(() =>
281+ VStack(
282+ {
283+ onKeyPress: (key) => {
284+ parentKey = key;
285+ },
286+ },
287+ [
288+ TextInput({
289+ value,
290+ focused: true,
291+ onChange: (v) => {
292+ value = v;
293+ },
294+ onKeyPress: (key) => {
295+ // only intercept enter
296+ if (key === "enter") return false;
297+ },
298+ }),
299+ ],
300+ ),
301+ );
302+ await waitForRender();
303+
304+ // ctrl+s is not intercepted by onKeyPress, and not an editing key — bubbles up
305+ term.sendInput(CTRL_S);
306+ await waitForRender();
307+
308+ expect(parentKey).toBe("ctrl+s"); // Bubbled up
309+ expect(value).toBe("hi"); // Unchanged
178310 });
179311
180312 test("modifier keys bubble up (not consumed by TextInput)", async () => {